Skip to content

Docs: trivial grammar fix to GettingStarted.md #9063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Docs: trivial grammar fix to GettingStarted.md #9063

merged 1 commit into from
Oct 19, 2019

Conversation

eddies
Copy link
Contributor

@eddies eddies commented Oct 18, 2019

Summary

Trivial grammar fix: corrects "they are ran" to "they are run"

@codecov-io
Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #9063 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9063   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files         277      277           
  Lines       11681    11681           
  Branches     2864     2864           
=======================================
  Hits         7485     7485           
  Misses       3572     3572           
  Partials      624      624

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc74b51...3d0e0ec. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Oct 18, 2019

Thanks! We have a few versioned versions of this document, would you mind updating those as well?

image

Use the past participle of run, i.e. "run"
@eddies
Copy link
Contributor Author

eddies commented Oct 19, 2019

@SimenB also applied to version-24.6/GettingStarted.md and README.me. Didn't find any other instances.

Copy link
Collaborator

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeysal jeysal merged commit b3fee0a into jestjs:master Oct 19, 2019
@eddies eddies deleted the patch-1 branch October 19, 2019 14:53
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants