-
Notifications
You must be signed in to change notification settings - Fork 258
Added-ruby-config #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Added-ruby-config #2991
Conversation
buildtools/cli.go
Outdated
Name: "ruby-config", | ||
Aliases: []string{"rubyc"}, | ||
Flags: cliutils.GetCommandFlags(cliutils.RubyConfig), | ||
Usage: gradleconfig.GetDescription(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why gradeconfig description ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo
@@ -1821,6 +1824,9 @@ var commandFlags = map[string][]string{ | |||
global, serverIdResolve, serverIdDeploy, repoResolve, repoDeploy, usesPlugin, UseWrapper, deployMavenDesc, | |||
deployIvyDesc, ivyDescPattern, ivyArtifactsPattern, | |||
}, | |||
RubyConfig: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing Ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only want to add the ruby-config, should I remove the ruby and only keep ruby-config ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Added ruby-config