Skip to content

Update entity generator to support reactive applications #11404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
mraible opened this issue Feb 28, 2020 · 8 comments · Fixed by #11416
Closed
4 tasks done

Update entity generator to support reactive applications #11404

mraible opened this issue Feb 28, 2020 · 8 comments · Fixed by #11416
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: reactive ⚛️ Spring WebFlux $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mraible
Copy link
Contributor

mraible commented Feb 28, 2020

Overview of the feature request

One of the last remaining items to move our Reactive/WebFlux support (#7608) to beta is to update the entity generator and its tests.

  • Entities with service
  • Entities without service
  • Entities tests with WebTestClient
Motivation for or Use Case

I'm opening these tasks as a new issue so we can assign a bug bounty to it and hopefully accelerate its development. Selfishly, I'd like to demo our WebFlux support with microservices in March.

Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@mraible mraible added area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ theme: reactive ⚛️ Spring WebFlux labels Feb 28, 2020
@mraible
Copy link
Contributor Author

mraible commented Feb 28, 2020

@pascalgrimaud I created a "reactive" label, but then realized maybe it should be named "theme: reactive"?

@pascalgrimaud
Copy link
Member

yes, theme: reactive is better to keep consistency. I'm surprised that it didn't exist yet

@murdos
Copy link
Contributor

murdos commented Feb 28, 2020

FYI, unless someone else is already working on it, I'll try to handle this task.

@cbornet
Copy link
Member

cbornet commented Feb 29, 2020

I'm not sure you can assign the work to yourself if there's a bounty on it 😃 . Anyway please go ahead. I at least won't try to compete on this.

@murdos
Copy link
Contributor

murdos commented Feb 29, 2020

@cbornet : I'm just trying to avoid duplicated effort, and thus announcing that I'm currently working on it (https://github.com/murdos/generator-jhipster/tree/reactive-entity-server). I'll open a draft when I got a full use case complete (e.g. entity without service).

But I see your point, I've unassigned myself from the ticket.

@murdos murdos removed their assignment Feb 29, 2020
@cbornet
Copy link
Member

cbornet commented Mar 1, 2020

BTW I've started working on SQL/R2DBC support. For the entity gen you can maybe ignore SQL for now.

@mraible
Copy link
Contributor Author

mraible commented Mar 29, 2020

@murdos Are you still planning to add support for Elasticsearch? Also, did you get the bounty for this?

@murdos
Copy link
Contributor

murdos commented Mar 29, 2020

Are you still planning to add support for Elasticsearch?

Yes. I got something working at last. I need to report the changes to the templates, you should have a PR during the week to come.

Also, did you get the bounty for this?

Not yet.

Regarding r2dbc entity support, I'm inclined to wait the availability of spring-projects/spring-data-r2dbc#282 in a milestone before really starting, it should really ease the work (and also simplify the existing User and PersistenceAuditEvent r2dbc repositories).

Also I noted that R2DBC support has been added in Spring Boot 2.3 M3, so the experimental spring boot starter is now deprecated (or at least not updated it seems) and there are some breaking changes that we'll need to handle.

@pascalgrimaud pascalgrimaud added this to the 6.9.0 milestone Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: reactive ⚛️ Spring WebFlux $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants