Support of query derivation #282

rchigvintsev · 2020-01-22T11:54:26Z

I have a simple conceptual implementation of query derivation partly based on corresponding code in spring-data-jpa and Hibernate projects. For now it looks a bit messy and needs to be put in order. I could clean the code, write several test and then create a pull request so you could review a solution.

Is it worth doing or you guys are already in the middle of developing such feature?

mp911de · 2020-01-22T12:45:23Z

Thanks for reaching out. We want to add query derivation to Spring Data R2DBC. We're currently in the planning so we can add query derivation to both projects, Spring Data JDBC and R2DBC to keep both projects in sync, time- and feature-wise. Check out the corresponding ticket DATAJDBC-318.

rchigvintsev · 2020-01-22T13:43:50Z

I've made a quick look at James Clark's solution (from discussion in ticket it seems like a major solution) and compared it with mine. My approach is similar: PartTree-based implementation of AbstractR2dbcQuery and query generation using classes from spring-data-relational.

For now I don't understand how spring-data-jdbc and spring-data-r2dbc are going to be in sync. Classes like AbstractJdbcRepositoryQuery or JdbcQueryCreator should obviously be project-specific. Is synchronization only related to features that will be added to spring-data-relational and spring-data-commons projects?

mp911de · 2020-01-22T13:52:29Z

The synchronization is mostly to keep both SQL-based projects on the same level of functionality (i.e. timing-wise and what the query derivation is capable of). Paging @schauder as Jens is involved already in Spring Data JDBC.

I'm not sure, probably the only thing that is holding us from building query derivation in Spring Data JDBC is the required dialect support.

rchigvintsev · 2020-01-22T14:12:21Z

OK. Thanks for clarification! But I still don't see an answer to the question that I asked above: is it worth for me to keep going and provide a PR or you are going to wait for finishing of DATAJDBC-318 and then adopt it to this project?

mp911de · 2020-01-22T14:15:19Z

Probably it makes the most sense that a single contributor takes care of both changes. Alternatively, we can move forward with R2DBC and adapt that functionality in JDBC as it seems that we can make more progress with Spring Data R2DBC right now.

schauder · 2020-01-22T14:22:59Z

The situation of DATAJDBC-318 is a little unfortunate, since there exist two solutions but no proper PR and I did not get a reply on my request to receive such a PR. If you @rchigvintsev would provide a PR for DATAJDBC-318 I (and maybe @mp911de ) would review it in a timely fashion. And once that is done we could move forward and port it to Spring Data R2DBC.

How does that sound for a plan?

mp911de · 2020-01-22T14:31:06Z

I think porting works either way. Either from JDBC to R2DBC or vice versa. In any case, I like the idea and I'm happy that we can progress here.

rchigvintsev · 2020-01-22T15:14:41Z

@schauder For me it is easer to stick to R2DBC (since I've already done some work on this feature) and provide a PR here possibly looking at the solutions from DATAJDBC-318 to make future porting simpler.

On the other side single contributor is definitely a good option and it seems like work on DATAJDBC-318 is almost done.

schauder · 2020-01-22T15:18:34Z

@rchigvintsev then please go ahead and create a proper PR for R2DBC. DATAJDBC is in an unhealthy state right now as I tried to explain above.

rchigvintsev · 2020-01-22T15:26:48Z

@schauder OK, I will try to prepare basic solution as soon as possible.

rchigvintsev · 2020-02-03T13:18:14Z

PR: #295

…cQueryCreator

…ndition

…o be able to build SQL manually

…itions

… operators

…GATING_SIMPLE_PROPERTY' conditions

…'NOT CONTAINING' condition

…ery' for 'PartTreeR2dbcQuery'

…ry explicitly associated with repository method

…ntation of 'io.r2dbc.spi.Statement' may not support binding

… Relational

…rmatting settings

…es in Spring Data Relational

… whether parameter is scalar

…ng convention

… instead of 'StatementBuilder'

We now support query derivation for R2DBC repositories: interface ReactivePersonRepository extends ReactiveSortingRepository<Person, String> { Flux<Person> findByFirstname(String firstname); Flux<Person> findByFirstname(Publisher<String> firstname); Mono<Person> findByFirstnameAndLastname(String firstname, String lastname); Flux<Person> findFirstByLastnameLike(String pattern); } Original pull request: #295.

Move query derivation infrastructure to Spring Data Relational. Adapt to newly introduced ValueFunction for deferred value mapping. Use query derivation in integration tests. Tweak javadoc, add since and author tags, reformat code. Related ticket: https://jira.spring.io/browse/DATAJDBC-514 Original pull request: #295.

Original pull request: #295.

mp911de · 2020-03-27T15:54:55Z

The PR is merged now.

mp911de added the type: enhancement A general enhancement label Jan 22, 2020

rchigvintsev mentioned this issue Feb 3, 2020

#282 - Support of query derivation #295

Closed

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Starting point for PartTree-based query derivation

e266d0d

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Generate simplest SQL without condition in R2db…

46bae29

…cQueryCreator

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Allow to create queries with simple equality co…

90c84df

…ndition

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add test of 'IS NULL' condition

a13c2c8

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Expose 'RenderContext' from 'StatementMapper' t…

3871f0b

…o be able to build SQL manually

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Limit query in case of 'exists' projection

0d415df

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add Copyright License headers to new files

497e604

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Implement conjunction of conditions

d552ec1

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Implement disjunction of conditions

b222607

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Implement query parameter binding

21e35b2

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of 'BETWEEN' operator

bab4c7e

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of 'LESS/GREATER THAN (EQUAL)' cond…

0944f8a

…itions

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of 'AFTER/BEFORE' conditions

61083bf

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of 'IS (NOT) NULL' and '(NOT) LIKE'…

39c745a

… operators

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of 'STARTING/ENDING WITH' conditions

cca24c8

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of 'CONTAINING' conditions

7c135fe

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Support ordering

7095113

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of '(NOT) IN', 'TRUE/FALSE' and 'NE…

91b4660

…GATING_SIMPLE_PROPERTY' conditions

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add support of case insensitive conditions and …

6358eed

…'NOT CONTAINING' condition

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add some error tests for 'PartTreeR2dbcQuery'

cf32380

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Add a few more tests for 'PartTreeR2dbcQuery'

0bb11da

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Changes in JavaDocs

d3017d1

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Create standalone implementation of 'BindableQu…

a58003b

…ery' for 'PartTreeR2dbcQuery'

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Use 'PartTreeR2dbcQuery' by default when no que…

88a0cfd

…ry explicitly associated with repository method

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Use named parameters in SQL query since impleme…

9482e44

…ntation of 'io.r2dbc.spi.Statement' may not support binding

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Adapt to 'SqlIdentifier' changes in Spring Data…

616fa0c

… Relational

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Bring new code in line with Spring Data code fo…

430aa6d

…rmatting settings

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 14, 2020

spring-projects#282 - Adapt ConditionFactory to 'SqlIdentifier' chang…

2fb7303

…es in Spring Data Relational

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 16, 2020

spring-projects#282 - Fix year in copyright header of new files

883a52c

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 16, 2020

spring-projects#282 - Use Collection instead of Iterable to determine…

a00ffb8

… whether parameter is scalar

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 16, 2020

spring-projects#282 - Rename new test classes in accordance with nami…

b40f9c0

…ng convention

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 16, 2020

spring-projects#282 - Add more unit tests for LikeEscaper

d1d55d7

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 17, 2020

spring-projects#282 - Add support of limiting query results

53d01ba

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 19, 2020

spring-projects#282 - Improve code readability

37b2dbf

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 19, 2020

spring-projects#282 - Get rid of Lombok annotations in new code

ab7a3ac

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 23, 2020

spring-projects#282 - Use 'StatementMapper' to create 'BindableQuery'…

1e282e1

… instead of 'StatementBuilder'

rchigvintsev added a commit to rchigvintsev/spring-data-r2dbc that referenced this issue Mar 23, 2020

spring-projects#282 - Use 'StatementMapper' to create 'BindableQuery'…

e5abd58

… instead of 'StatementBuilder'

mp911de added this to the 1.1 RC1 (Neumann) milestone Mar 27, 2020

mp911de added a commit that referenced this issue Mar 27, 2020

#282 - Add documentation.

020d46b

Original pull request: #295.

mp911de closed this as completed Mar 27, 2020

murdos mentioned this issue Mar 29, 2020

Update entity generator to support reactive applications jhipster/generator-jhipster#11404

Closed

4 tasks

cbornet mentioned this issue Apr 3, 2020

[Reactive] Support R2DBC in entity generator jhipster/generator-jhipster#11542

Closed

mp911de mentioned this issue Apr 21, 2020

Pageable not supported with String @Query #276

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support of query derivation #282

Support of query derivation #282

rchigvintsev commented Jan 22, 2020

mp911de commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

mp911de commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

mp911de commented Jan 22, 2020

schauder commented Jan 22, 2020

mp911de commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

schauder commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

rchigvintsev commented Feb 3, 2020

mp911de commented Mar 27, 2020

Support of query derivation #282

Support of query derivation #282

Comments

rchigvintsev commented Jan 22, 2020

mp911de commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

mp911de commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

mp911de commented Jan 22, 2020

schauder commented Jan 22, 2020

mp911de commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

schauder commented Jan 22, 2020

rchigvintsev commented Jan 22, 2020

rchigvintsev commented Feb 3, 2020

mp911de commented Mar 27, 2020