Skip to content

[Reactive] Support R2DBC in entity generator #11542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbornet opened this issue Apr 3, 2020 · 12 comments
Closed

[Reactive] Support R2DBC in entity generator #11542

cbornet opened this issue Apr 3, 2020 · 12 comments
Assignees
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: reactive ⚛️ Spring WebFlux $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@cbornet
Copy link
Member

cbornet commented Apr 3, 2020

We now have support for r2dbc in the main generator and entity generation for NoSQL databases.
So remains r2dbc entity generation.

Some things that make it not so easy:

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Apr 26, 2020
@mraible
Copy link
Contributor

mraible commented Apr 26, 2020

I've added a bug bounty as this seems like a large task that will be difficult to do.

@gzsombor
Copy link
Member

I would like to work on it - I've already found a couple of issue, which prevented running the reactive app, and login to it.

@mraible
Copy link
Contributor

mraible commented Apr 27, 2020

Go for it @gzsombor!

@gzsombor gzsombor self-assigned this Apr 28, 2020
@brahimk
Copy link

brahimk commented Jul 8, 2020

Hello @gzsombor

Do you want help on this issue ?

thanks.

@gzsombor
Copy link
Member

gzsombor commented Jul 8, 2020

@brahimk thanks for asking, there are some progress implementing this - and there is an open PR about
#11742 .
Currently I'm blocked by three things:

@mraible
Copy link
Contributor

mraible commented Oct 8, 2020

@gzsombor Are you still blocked? Can we split this up into smaller issues and give you more $$ to make it happen?

@murdos
Copy link
Contributor

murdos commented Oct 8, 2020

@mraible : as far as I can tell, this ticket should be closed as resolved, since #11742 has been merged.

@mraible
Copy link
Contributor

mraible commented Oct 8, 2020

Fixed by #11742. I'm not sure how to do the bug bounty payout. Maybe @pascalgrimaud can help?

@mraible mraible closed this as completed Oct 8, 2020
@gzsombor
Copy link
Member

gzsombor commented Oct 8, 2020

Yes, sorry, the code has been merged, but there are a couple of open issues, in decreasing importance:

  • filtering is not implemented
  • the generated code is still more complex, and need more maintenance, then I would like to have. If someone adds a new column to an entity - they need to change a couple of things: add it into the mapper class, the repository impl class, and to the sql helper class. As these code looks pretty boring and repetitive, it would be nice, if this could be created either compile time (with an annotation processing tool, with something similar to mapstruct), or runtime.
  • Doesnt work well with MSSQL and Oracle.

I guess, they can be implemented - and improved - if there will be user demand 😉

@pascalgrimaud
Copy link
Member

@mraible : as far as I can understand, the work was done mainly by @gzsombor with the 86 commits so the full bounty is for him, and well deserved
if other people participated, just tell us, and we'll see what we can do

@gzsombor
Copy link
Member

gzsombor commented Oct 9, 2020

@pascalgrimaud
Copy link
Member

@gzsombor : approved

@pascalgrimaud pascalgrimaud added this to the 7.0.0 milestone Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: reactive ⚛️ Spring WebFlux $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

No branches or pull requests

6 participants