-
Notifications
You must be signed in to change notification settings - Fork 15
DO NOT MERGE Tests for async-deadlock fix #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jhugman
wants to merge
8
commits into
jhugman/fixup-async-deadlock
from
jhugman/tests-for-async-deadlock
Closed
DO NOT MERGE Tests for async-deadlock fix #89
jhugman
wants to merge
8
commits into
jhugman/fixup-async-deadlock
from
jhugman/tests-for-async-deadlock
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67eb94d
to
e5c2539
Compare
3fb30a4
to
443a7a0
Compare
Added console.logs to verify ordering of the calls to and from JS. The following test run is relatively short, but it shows:
/cc @zzorba |
Thank you for update -- very informative. Let me know if it's worth trying to incorporate this into my test branch. |
49085d4
to
422bd95
Compare
422bd95
to
d0b5904
Compare
443a7a0
to
56ce2e9
Compare
d0b5904
to
86a80c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test bed for the fix #88 .
Because it depends on a fork of the matrix-rust-sdk, and it makes network calls, we should not check this in as part of the ubrn repo.