Skip to content

Surge example #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Surge example #29

merged 5 commits into from
Dec 1, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Dec 1, 2024

adds example using https://surgemsg.com/ to text myself from claude

fastmcp install examples/text_me.py -f .env && fastmcp run examples/text_me.py

also updates tests to only run on changes to src, tests, and dep-related files

@github-actions github-actions bot added enhancement New feature or request good first issue Good for newcomers labels Dec 1, 2024
Copy link
Owner

@jlowin jlowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind adding some brief documentation to the top of the example file - maybe what env vars to set or how to deploy with env

# ///

"""
FastMCP Echo Server
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FastMCP Echo Server
FastMCP Surge Server

@@ -0,0 +1,59 @@
# /// script
# dependencies = ["fastmcp"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be unecessary as fastmcp always adds itself as a dependency but 👍 good practice. I did learn that if you have a script declaration like this it overrules all other dependencies though

@zzstoatzz
Copy link
Collaborator Author

good calls @jlowin - added in cbb8dbe

@zzstoatzz zzstoatzz merged commit 288e80c into main Dec 1, 2024
1 check passed
@zzstoatzz zzstoatzz deleted the surge-example branch December 1, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants