Skip to content

fix warning and flake #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix warning and flake #47

merged 2 commits into from
Dec 3, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Dec 3, 2024

see warnings and failures https://github.com/jlowin/fastmcp/actions/runs/12131427611

  • fix pytest warnings "cannot collect" TestClassNotGroupingCases -> SomeClassNotGroupingCases
  • order-independent check for test_dev_with_dependencies
  • adds pytest-flakefinder as a dev dep so I can do
» pytest tests/test_cli.py -k with_dep --flake-finder

tests/test_cli.py ....................................................................................................    [100%]

======= 100 passed, 600 deselected in 0.84s ======

@github-actions github-actions bot added the bug Something isn't working label Dec 3, 2024
@zzstoatzz zzstoatzz removed the bug Something isn't working label Dec 3, 2024
@zzstoatzz zzstoatzz marked this pull request as ready for review December 3, 2024 02:13
@zzstoatzz zzstoatzz added the development fixing tests, tech debt, maintenance label Dec 3, 2024
@jlowin jlowin merged commit d90de08 into main Dec 3, 2024
4 checks passed
@jlowin jlowin deleted the warning-and-flake branch December 3, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development fixing tests, tech debt, maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants