First-class support for `$fisher_path`

[jorgebucaran]

We can customize the installation path using $fisher_path, but Fisher doesn't help you with the boilerplate code necessary to load it during startup. It would be great if Fisher did all this work when you're using a custom $fisher_path.

Something like this via $__fish_config/conf.d/fisher.fish would do it:

set --query fisher_path || exit

set fish_function_path $fish_function_path[1] $fisher_path/functions $fish_function_path[2..-1]
set fish_complete_path $fish_complete_path[1] $fisher_path/completions $fish_complete_path[2..-1]

for file in $fisher_path/conf.d/*.fish
    source $file
end

[vamega]

I was able to make this work with the following snippet. I couldn't use the return since the code isn't running in a function, and had to switch to using cat since the the redirection didn't work when there were multiple files in the conf.d directory.

if set --query fisher_path

    set fish_function_path $fish_function_path[1] $fisher_path/functions $fish_function_path[2..-1]
    set fish_complete_path $fish_complete_path[1] $fisher_path/completions $fish_complete_path[2..-1]

    set --local files $fisher_path/conf.d/*.fish && set --query files[1] && cat $files | source
end

[jorgebucaran]

I should've used exit and just a for loop instead, thanks! @vamega

[kidonng]

👋 I write a simple plugin to make $fisher_path work in one-line:

curl -sSL https://git.io/fisher_path.fish --create-dirs -o $__fish_config_dir/conf.d/fisher_path.fish

@jorgebucaran is there any plans on adding a "out of the box" support for $fisher_path?

It would be really nice to have this without the need of extra boilerplate code or third party plugins

[jorgebucaran]

Sorry, not at this time. I get that out-of-the-box support would be nice to have for some, but using a plugin like @kidonng's works just as well, allowing me to keep Fisher simple, which is also in the interest of all of us.

I see your point, but wouldn't it be counter-intuitive to have a variable that only instructs the plugin manager where to install the plugins, when you need to manually write extra configuration to actually be able to make use of those installed plugins?

Shouldn't it be part of fisher project scope?

[jorgebucaran]

You are right, which is why using $fisher_path was essentially a "hack" until we decided to document it.

I am not completely made up my mind about this yet, which is why the issue is still open.

[kidonng]

@henriquehbr Just want to say that while it is possible to use it as a Fisher plugin, the recommend way to use it is to put it in ~/. config/fish/conf.d or copy the snippet to your config.fish.

@kidonng What would be the possible pitfalls of using it as a fisher plugin?

At the moment, i'm using it in my config.fish and it's working fine, but i also considered the option of using it as a plugin for keeping config.fish clean

[kidonng]

You will still need some boilerplate code like source $fisher_path/conf.d/fisher_path.fish in order for it to work. Also I don't think it will be updated often (if it even needs update, that is), you can just put it in your ~/. config/fish/conf.d and relax.

[jorgebucaran]

Why do you need that boilerplate? @kidonng.