Skip to content

add a nothing-check in isglobal #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2020
Merged

add a nothing-check in isglobal #223

merged 2 commits into from
Dec 11, 2020

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Nov 23, 2020 •
edited
Loading

Fixes

MethodError: no method matching scopehasbinding(::Nothing, ::String)
Closest candidates are:
  scopehasbinding(!Matched::StaticLint.Scope, ::String) at c:\Users\...\.vscode\extensions\julialang.language-julia-1.0.10\scripts\packages\StaticLint\src\scope.jl:57

The second commit should fix

MethodError: no method matching get_named_toplevel_module(::StaticLint.Scope, ::Nothing)
Closest candidates are:
  get_named_toplevel_module(::StaticLint.Scope, !Matched::String) at /Users/.../.vscode/extensions/julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/imports.jl:90 
MethodError:
   at _get_field(::Dict{Symbol,SymbolServer.ModuleStore}, ::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/imports.jl101)
   at resolve_import(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/imports.jl14)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl59)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at traverse(::CSTParser.EXPR, ::StaticLint.Toplevel{LanguageServer.Document}) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl129)
   at (::StaticLint.Toplevel{LanguageServer.Document})(::CSTParser.EXPR) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/StaticLint.jl71)
   at scopepass(::LanguageServer.Document, ::LanguageServer.Document) (./julialang.language-julia-1.0.10/scripts/packages/StaticLint/src/server.jl45)
   at parse_all(::LanguageServer.Document, ::LanguageServerInstance) (./julialang.language-julia-1.0.10/scripts/packages/LanguageServer/src/requests/textdocument.jl237)
   at workspace_didChangeWatchedFiles_notification(::LanguageServer.DidChangeWatchedFilesParams, ::LanguageServerInstance, ::JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint,Base.PipeEndpoint}) (./julialang.language-julia-1.0.10/scripts/packages/LanguageServer/src/requests/workspace.jl46)
   at (::LanguageServer.var"#125#158"{LanguageServerInstance})(::JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint,Base.PipeEndpoint}, ::LanguageServer.DidChangeWatchedFilesParams) (./julialang.language-julia-1.0.10/scripts/packages/LanguageServer/src/languageserverinstance.jl298)
   at dispatch_msg(::JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint,Base.PipeEndpoint}, ::JSONRPC.MsgDispatcher, ::Dict{String,Any}) (./julialang.language-julia-1.0.10/scripts/packages/JSONRPC/src/typed.jl66)
   at run(::LanguageServerInstance) (./julialang.language-julia-1.0.10/scripts/packages/LanguageServer/src/languageserverinstance.jl310)
   at top-level scope (./julialang.language-julia-1.0.10/scripts/languageserver/main.jl59)
   at include(::Function, ::Module, ::String) (Base.jl380)
   at include(::Module, ::String) (Base.jl368)
   at exec_options(::Base.JLOptions) (client.jl296)
   at _start() (client.jl506)

@pfitzseb pfitzseb added the bug label Nov 23, 2020
@pfitzseb pfitzseb requested a review from ZacLN November 23, 2020 21:12
@pfitzseb pfitzseb merged commit 4850e68 into master Dec 11, 2020
@davidanthoff davidanthoff deleted the sp/isglobalnothingcheck branch January 5, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

@ZacLN ZacLN Awaiting requested review from ZacLN

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfitzseb @aviatesk