Skip to content

fix sig unwrapping #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2021
Merged

fix sig unwrapping #258

merged 2 commits into from
Feb 3, 2021

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Feb 3, 2021

minor fix for #256 (comment)

Wait until after julia-vscode release has been pushed to merge.

@ZacLN ZacLN added the bug label Feb 3, 2021
@ZacLN ZacLN added this to the Next Minor milestone Feb 3, 2021
@ZacLN ZacLN self-assigned this Feb 3, 2021
davidanthoff
davidanthoff approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think given that we already merged things after we tagged 1.1.13, we might as well merge this also because we'll need a new build as a release candidate no matter what.

@davidanthoff davidanthoff merged commit 150a38a into master Feb 3, 2021
@davidanthoff davidanthoff deleted the sigs branch February 3, 2021 17:36
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff approved these changes

Assignees

@ZacLN ZacLN

Labels
bug
Projects
None yet
Milestone
Next Feature Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ZacLN @davidanthoff