Type inf improvements #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
reviewed
Feb 16, 2021
src/type_inf.jl
Outdated
| @@ -57,6 +57,8 @@ function infer_type_assignment_rhs(binding, state, scope) | |||
| settype!(binding, CoreTypes.Float64) | |||
| elseif CSTParser.isstringliteral(rhs) | |||
| settype!(binding, CoreTypes.String) | |||
| elseif headof(rhs) === :TRUE || headof(rhs) === :false | |||
There was a problem hiding this comment.
Why's one head :TRUE and the other :false? (C/S)hould we make those consistent?
|
@pfitzseb this is ready to go. I've added some other code since last reviewed but this is largely unused as of yet. |
|
Needs a merge conflict resolution. |
davidanthoff
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some rudimentary inference for elements of arrays.
For type inference by use (i.e. where we infer the type of a variable by the argument slot it sits in in a function call) adds handling for
ifblocks so that the uncertainty of whether a branch is hit is accounted for.Also adds some internal (as yet unused) functions for reasoning about the specific method being used at a call site. The intention is to use this in combination with function return type cached by SymbolServer to improve our inference. [Note - there are currently two different pieces of code that iterate across function methods (
check_callandinfer_type_by_use) and use of the functions referenced above would add a third. These should be combined/rationalised.]For every PR, please check the following: