Add Locale conversion format configuration property
#4492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
6 tasks
scordio
commented
Apr 19, 2025
Comment on lines
53
to
58
| public static final DefaultArgumentConverter INSTANCE = new DefaultArgumentConverter(); | ||
| private static final String DEFAULT_LOCALE_CONVERSION_FORMAT_PROPERTY_NAME = "junit.jupiter.params.arguments.conversion.locale.format"; | ||
|
|
||
| private DefaultArgumentConverter() { | ||
| // nothing to initialize | ||
| private static final Function<String, LocaleConversionFormat> CONFIGURATION_TRANSFORMER = value -> LocaleConversionFormat.valueOf( | ||
| value.trim().toUpperCase(Locale.ROOT)); |
There was a problem hiding this comment.
To reduce the change's footprint, I included the property and the converter here instead of in JupiterConfiguration (which isn't accessible right now in DefaultArgumentConverter).
Let me know if you see any limitations with this approach!
This comment was marked as outdated.
This comment was marked as outdated.
scordio
commented
Apr 20, 2025
Comment on lines
+94
to
+96
| if (targetType == Locale.class && getLocaleConversionFormat() == LocaleConversionFormat.BCP_47) { | ||
| return Locale.forLanguageTag((String) source); | ||
| } |
There was a problem hiding this comment.
I'm delaying the format retrieval via getLocaleConversionFormat() because I'm unsure if it would be safe to grab that value in the constructor and keep it internally.
If you think it could be fetched earlier, I'm happy to refactor it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Localeargument conversion not settinglanguageandcountryproperly #3141I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations