Slightly cleanup 2 js files #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use ES6 classes - Don't reach into the DOM to get build token and baseUrl. This will help with writing tests in the future - Use => functions, so we can stop writing `const that = this`. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions. Particularly, it does not rebind `this`, so we can continue to access the parent context's `this`. Eventually this could be part of a binder-client JS package that can be used by other projects (like thebe) Ref jupyterhub#1373
|
The test failures seem completely unrelated? |
Pathway towards making the functions more testable
yuvipanda
changed the title
|
definitely looks unrelated |
consideRatio
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Beautiful!
I spent quite a bit of time to look at this to compensate for me not being so fluent with ES6 / JS matters. I think this is good to go.
The test failures relates to k3s-io/k3s#4054 btw. While unrelated, they fail and block the actual tests that are relevant to see still work. I suggest we wait a while to see if they solve the k3s issue - I think at least it will be solved within 24 hours.
Amazing work @yuvipanda!!!
|
@consideRatio do you know why the pre-commit.ci PR is failing? |
|
Because it doesnt see a pre-commit config yet, ignore it for now. I enabled it for this repo for the pre-commit related pr. |
|
Thanks yuvi!!! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Sep 21, 2021
jupyterhub/binderhub#1382 Merge pull request #1382 from yuvipanda/new-class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For badge.js:
This will help with writing tests in the future
const that = this.See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions.
Particularly, it does not rebind
this, so we can continueto access the parent context's
this.For badge.js:
each syntax. Helps reduce boilerplate.
Eventually this could be part of a binder-client JS package that
can be used by other projects (like thebe)
Ref #1373