lab default only if available, change filepath definition
#1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fully overrideable with singleuser.cmd, singleuser.defaultUrl
- old filepath urls still open classic UI - form produces new `?labpath=` arg when a file path is chosen lab is still 'default', but choice is frozen at link-creation time instead of at visit-time
|
looks like pre-commit ci is running, despite no config (#1381) |
|
I've now disabled pre-commit.ci again in https://github.com/organizations/jupyterhub/settings/installations/17782968/update! |
1 task
hackfin
added a commit
to hackfin/cyrite.howto
that referenced
this pull request
Sep 23, 2021
Check for final solution with jupyterhub/binderhub#1383
Co-authored-by: Erik Sundell <[email protected]>
consideRatio
approved these changes
Sep 24, 2021
|
test failure was a DNS failure to resolve discourse.jupyter.org, the kind of once-in-a-while CI networking issue that just happens sometimes. I don't think it's related. Relaunched anyway, though. |
|
I'd like to merge this directly if tests succeed. I believe it is a very relevant fix and we see above that it has been referenced as something awaited as a fix. |
|
all green |
|
Thank you so much for your work on this @minrk!!! ❤️ 🎉 |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Sep 24, 2021
jupyterhub/binderhub#1383 Merge pull request #1383 from minrk/detect-lab-default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
?filepathdefinition from "open with current UI" to "open with classic notebook" to match apparent user expectations.two pieces of #1368 :
?labpathinstead of?filepath.filepathis permanently frozen to mean/tree/...with the classic UI?labpathurl, not afilepathurlsingleuser.cmdso that we can set lab as the default url if jupyterlab 3 is availableIf no filepath is specified, and lab 3 is available, lab is still the default UI, leaving it the only link with changed behavior.
@betatim proposed reserving lab-by-default to
/v3/to make the UI change fully explicit and opt-in. I think that if we go all the way to defining av3url, we should also change the server launch command tojupyter labinstead ofjupyter notebook, because we know that change will be significantly more disruptive, and is also going to happen eventually. It's also a lot simpler to say "v3 starts jupyterlab" than the UI is changed, but the server is not.We specifically chose this 'only switch default ui' to avoid breaking existing links, so if we are making new links, I think we should update the server command to the current standard, too, rather than having to do this all over again in a few months.
I think we can also communicate a lot better (and take some steps) to address the fact that UI customizations (extensions and such) are very often broken by repo2docker updates, because repo2docker sets the UI versions, not the user. The user may pin down UI, but this can break things, too. There is no good answer for now for stable links with extensions that don't need upkeep by the user.