feat(Cypress): Add routing test #4768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
C-feature
SamraatBansal
requested changes
Jun 4, 2024
Comment on lines
+19
to
+34
| cy.createConnectorWithNameCallTest( | ||
| createConnectorBody, | ||
| "adyen", | ||
| "payment_processor", | ||
| globalState, | ||
| ); | ||
| }); | ||
|
|
||
| it("stripe-connector-create-call-test", () => { | ||
| cy.createConnectorWithNameCallTest( | ||
| createConnectorBody, | ||
| "stripe", | ||
| "payment_processor", | ||
| globalState, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Is this function used at multiple places?
If only added for routing test cases still it should be configurable, once discuss this with @vspecky
SamraatBansal
approved these changes
Jun 5, 2024
pixincreate
requested changes
Jun 7, 2024
| before("seed global state", () => { | ||
| cy.task("getGlobalState").then((state) => { | ||
| globalState = new State(state); | ||
| console.log("seeding globalState -> " + JSON.stringify(globalState)); |
There was a problem hiding this comment.
Can you please remove all the console logs that exposes globalState.
That includes cy.task("cli_log") stuffs as well. Let's keep that them only for debugging.
| }); | ||
| }); | ||
| after("flush global state", () => { | ||
| console.log("flushing globalState -> " + JSON.stringify(globalState)); |
| before("seed global state", () => { | ||
| cy.task("getGlobalState").then((state) => { | ||
| globalState = new State(state); | ||
| console.log("seeding globalState -> " + JSON.stringify(globalState)); |
| }); | ||
| }); | ||
| after("flush global state", () => { | ||
| console.log("flushing globalState -> " + JSON.stringify(globalState)); |
| before("seed global state", () => { | ||
| cy.task("getGlobalState").then((state) => { | ||
| globalState = new State(state); | ||
| console.log("seeding globalState -> " + JSON.stringify(globalState)); |
| }); | ||
|
|
||
| after("flush global state", () => { | ||
| console.log("flushing globalState -> " + JSON.stringify(globalState)); |
Comment on lines
+20
to
+24
| console.log("seeding globalState -> " + JSON.stringify(globalState)); | ||
| cy.task( | ||
| "cli_log", | ||
| "SEEDING GLOBAL STATE -> " + JSON.stringify(globalState), | ||
| ); |
Comment on lines
+31
to
+34
| cy.task( | ||
| "cli_log", | ||
| " FLUSHING GLOBAL STATE -> " + JSON.stringify(globalState), | ||
| ); |
pixincreate
approved these changes
Jun 7, 2024
pixincreate
added a commit
that referenced
this pull request
Jun 7, 2024
…o cypress-payout-fix * 'main' of github.com:juspay/hyperswitch: feat(Cypress): Add routing test (#4768) feat(connector): [BOA] Handle refund status 201 (#4908) * 'main' of github.com:juspay/hyperswitch: feat(Cypress): Add routing test (#4768) feat(connector): [BOA] Handle refund status 201 (#4908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add service level test for Routing
Additional Changes
Motivation and Context
How did you test it?
Tested through Cypress
Checklist
cargo +nightly fmt --allcargo clippy