Update HandlerMappingIntrospector Usage in CORS support #35
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Thanks, @evgeniycheban! I left a comment inline. Also, gh-16429 has been merged, so would you please open a new PR in Spring Security?
| return new CorsFilter(mappingIntrospector); | ||
| PreFlightRequestHandler mappingIntrospector = context.getBean(HANDLER_MAPPING_INTROSPECTOR_BEAN_NAME, | ||
| PreFlightRequestHandler.class); | ||
| return new CorsFilter((CorsConfigurationSource) mappingIntrospector); |
There was a problem hiding this comment.
Please do a safe cast here, and then throw an exception if it isn't of the right type.
There was a problem hiding this comment.
Wouldn't it be better to look up for CorsConfigurationSource?
evgeniycheban
force-pushed
the
gh-16501
branch
from
c3d623b to
436345a
Compare
|
@jzheaux I opened a PR to Spring Security repository |
evgeniycheban
force-pushed
the
gh-16501
branch
from
436345a to
b591246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes spring-projectsgh-16501