Skip to content

Fix empty list translation #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2023
Merged

Fix empty list translation #1224

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0081b56
wip
rsoeldner May 10, 2023
075facd
add test
rsoeldner May 10, 2023
8426122
Update src-tool/Pact/Analyze/Translate.hs
rsoeldner May 10, 2023
d096e9f
address review comments
rsoeldner May 10, 2023
aef44ad
Merge branch 'master' into rsoeldner/fix-1182
emilypi May 15, 2023
2b6d24f
Merge branch 'master' into rsoeldner/fix-1182
rsoeldner May 16, 2023
82db2df
Merge branch 'rsoeldner/fix-1182' of github.com:kadena-io/pact into r…
rsoeldner May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src-tool/Pact/Analyze/Translate.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,13 @@ translateNode astNode = withAstContext astNode $ case astNode of

AST_NFun node "list" _ -> throwError' $ DeprecatedList node

-- rs (2023-05-10): Note, we handle the empty list properly (see #1182)
-- as the element type is otherwise inferred as `Any`.
AST_List node [] -> translateType node >>= \case
EType retTy -> case retTy of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it called retTy here? What is node at this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retTy is the return type of the translation step, i.e. SList SStr. I will change it to listTy.

The node is of type Node from the Typecheck module, see here. For the particular example above, its TyList {_tyListType = TyPrim TyString}.

SList _ -> pure $ Some retTy $ CoreTerm $ Lit []
_ -> throwError' $ TypeError node

AST_List node elems -> do
elems' <- traverse translateNode elems
Some ty litList <- mkLiteralList elems' ?? TypeError node
Expand Down
8 changes: 8 additions & 0 deletions tests/AnalyzeSpec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4564,3 +4564,11 @@ spec = describe "analyze" $ do
(enforce false ""))
|]
"Vacuous property encountered!"

describe "regression #1182" $ do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be nice for the description to be self-contained.

expectVerified [text|
(defun test:[string] (x: [string])
@model [(property (= x x))]
(let ((default-val:[string] [])) default-val)
x)
|]