Skip to content

BE: Exclude offline nodes from target calculation when adjusting the replication factor #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2025

Conversation

germanosin
Copy link
Member

@germanosin germanosin commented Jun 6, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #1117

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@germanosin germanosin requested a review from a team as a code owner June 6, 2025 08:45
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jun 6, 2025
@germanosin germanosin added scope/backend Related to backend changes type/bug Something isn't working labels Jun 6, 2025
@germanosin germanosin added this to the 1.3 milestone Jun 6, 2025
@germanosin germanosin self-assigned this Jun 6, 2025
@Haarolean Haarolean changed the title Fixes #1117: Removing offline nodes from target calculation BE: Remove offline nodes from target calculation Jun 6, 2025
@germanosin germanosin changed the title BE: Remove offline nodes from target calculation BE: Exclude offline nodes from target calculation when adjusting the replication factor. Jun 6, 2025
@germanosin germanosin changed the title BE: Exclude offline nodes from target calculation when adjusting the replication factor. BE: Exclude offline nodes from target calculation when adjusting the replication factor Jun 6, 2025
@germanosin germanosin merged commit ad3ac5c into main Jun 7, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 1.3 Jun 7, 2025
@germanosin germanosin deleted the issue/1117 branch June 7, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/topics scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

replication.factor fail on topic with URP not null
3 participants