Skip to content

.github/workflows/installation-charts.yaml: update Helm and Kustomize to latest versions #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

mohamedawnallah
Copy link
Member

@mohamedawnallah mohamedawnallah commented Apr 23, 2025

Motivation and Context

Follow-up on #5638 (comment).

What type of PR is this?

/kind failing-test

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.26%. Comparing base (d58cbe1) to head (e19e324).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6318      +/-   ##
==========================================
+ Coverage   48.15%   48.26%   +0.10%     
==========================================
  Files         677      677              
  Lines       56068    56067       -1     
==========================================
+ Hits        26999    27058      +59     
+ Misses      27298    27237      -61     
- Partials     1771     1772       +1     
Flag Coverage Δ
unittests 48.26% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mohamedawnallah mohamedawnallah changed the title test CI with updated helm release version .github/workflows/installation-charts.yaml: update Helm and Kustomize to latest versions Apr 23, 2025
@mohamedawnallah
Copy link
Member Author

/cc @zhzhuang-zju

@zhzhuang-zju
Copy link
Contributor

zhzhuang-zju commented Apr 23, 2025

Regarding the issue that the CI: Chart/Test on Kubernetes is bound to fail recently, I found the same issue in the helm repository: helm/helm#11521, and the relevant bugfix has been merged into v3.12.2. I tried upgrading helm to v3.12.2 in my own repository and it also solved this problem. Although I haven't figured out the root cause of this issue yet, from the result perspective, the upgrade can indeed solve the problem. WDYT? @RainbowMango @XiShanYongYe-Chang

@zhzhuang-zju
Copy link
Contributor

/lgtm
cc @XiShanYongYe-Chang @RainbowMango for Approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok~
LGTM

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025
@karmada-bot karmada-bot merged commit c160708 into karmada-io:master Apr 23, 2025
24 checks passed
karmada-bot added a commit that referenced this pull request Apr 30, 2025
…6318-upstream-release-1.11

Automated cherry pick of #6318: .github/workflows: update helm and kustomize env
karmada-bot added a commit that referenced this pull request Apr 30, 2025
…6318-upstream-release-1.12

Automated cherry pick of #6318: .github/workflows: update helm and kustomize env
karmada-bot added a commit that referenced this pull request Apr 30, 2025
…6318-upstream-release-1.13

Automated cherry pick of #6318: .github/workflows: update helm and kustomize env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants