Skip to content

Automated cherry pick of #6284: update to 'predicate.GenerationChangedPredicate' in #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Apr 30, 2025

Cherry pick of #6284 on release-1.13.
#6284: update to 'predicate.GenerationChangedPredicate' in
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`/`karmada-agent`: Fixed the issue that cluster status update interval shorter than configured `--cluster-status-update-frequency`.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.99%. Comparing base (6b3bce2) to head (0f5accf).

Files with missing lines Patch % Lines
...kg/controllers/status/cluster_status_controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.13    #6335   +/-   ##
=============================================
  Coverage         47.99%   47.99%           
=============================================
  Files               674      674           
  Lines             55872    55872           
=============================================
+ Hits              26815    26816    +1     
+ Misses            27310    27309    -1     
  Partials           1747     1747           
Flag Coverage Δ
unittests 47.99% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RainbowMango RainbowMango force-pushed the automated-cherry-pick-of-#6284-upstream-release-1.13 branch from 90c5300 to 0f5accf Compare April 30, 2025 04:37
@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 30, 2025
@karmada-bot karmada-bot merged commit c292ad9 into karmada-io:release-1.13 Apr 30, 2025
23 checks passed
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants