Keras hub rename #1840
Merged
Keras hub rename #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just seeing how this does with tests for now. I'll mail this out later. |
mattdangerw
force-pushed
the
keras-hub-rename
branch
from
b8a80af to
635af20
Compare
mattdangerw
force-pushed
the
keras-hub-rename
branch
from
635af20 to
0a46364
Compare
divyashreepathihalli
approved these changes
Sep 18, 2024
SamanehSaadat
approved these changes
Sep 18, 2024
CONTRIBUTING_MODELS.md
Outdated
| assume that you want to contribute the DistilBERT model. Before we dive in, we encourage you to go through | ||
| [our getting started guide](https://keras.io/guides/keras_nlp/getting_started/) | ||
| [our getting started guide](https://keras.io/guides/keras_hub/getting_started/) |
There was a problem hiding this comment.
The keras.io paths will be updated before the keras-hub release, right? @divyashreepathihalli
There was a problem hiding this comment.
good catch! let's stick to the old paths for now, no sense breaking our links
CONTRIBUTING_MODELS.md
Outdated
| @@ -22,29 +22,29 @@ Keep this checklist handy! | |||
|
|
|||
| ### Step 2: PR #1 - Add XXBackbone | |||
|
|
|||
| - [ ] An `xx/xx_backbone.py` file which has the model graph \[[Example](https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/models/distil_bert/distil_bert_backbone.py)\]. | |||
| - [ ] An `xx/xx_backbone_test.py` file which has unit tests for the backbone \[[Example](https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/models/distil_bert/distil_bert_backbone_test.py)\]. | |||
| - [ ] An `xx/xx_backbone.py` file which has the model graph \[[Example](https://github.com/keras-team/keras-nlp/blob/master/keras_hub/models/distil_bert/distil_bert_backbone.py)\]. | |||
There was a problem hiding this comment.
Unrelated to this PR: the URL is broken (probably since we added api and src dirs)!
CONTRIBUTING_MODELS.md
Outdated
| - [ ] An `xx/xx_backbone.py` file which has the model graph \[[Example](https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/models/distil_bert/distil_bert_backbone.py)\]. | ||
| - [ ] An `xx/xx_backbone_test.py` file which has unit tests for the backbone \[[Example](https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/models/distil_bert/distil_bert_backbone_test.py)\]. | ||
| - [ ] An `xx/xx_backbone.py` file which has the model graph \[[Example](https://github.com/keras-team/keras-nlp/blob/master/keras_hub/models/distil_bert/distil_bert_backbone.py)\]. | ||
| - [ ] An `xx/xx_backbone_test.py` file which has unit tests for the backbone \[[Example](https://github.com/keras-team/keras-nlp/blob/master/keras_hub/models/distil_bert/distil_bert_backbone_test.py)\]. |
There was a problem hiding this comment.
We aren't changing the repo name in this PR, right?
There was a problem hiding this comment.
right, so hopefully this still works. we are changing the directory the code is in.
README.md
Outdated
| [](https://github.com/keras-team/keras-nlp/actions?query=workflow%3ATests+branch%3Amaster) | ||
|  | ||
| [](https://github.com/keras-team/keras-nlp/issues) | ||
|
|
||
| > [!IMPORTANT] | ||
| > KerasNLP is becoming KerasHub! Read the announcement [here](https://github.com/keras-team/keras-nlp/issues/1831). | ||
| > KerasHub is becoming KerasHub! Read the announcement [here](https://github.com/keras-team/keras-nlp/issues/1831). |
There was a problem hiding this comment.
This one should remain KerasNLP
mattdangerw
force-pushed
the
keras-hub-rename
branch
from
0a46364 to
96f900f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual rename commit! We are going to make our nightly package a preview of
keras-hub(withkeras-nlpprovided as a compat package).