Some routine cleanup while writing some new tools for checkpoint admin #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mattdangerw
commented
Dec 19, 2024
mattdangerw
commented
- Remove broken test in preset_utils we don't ever run
- Move load_serialized_object to our preset loading class (for consistency)
- Move all admin related tooling to a dedicated folder in tools/
- Remove some no longer used scripts.
mattdangerw
force-pushed
the
misc-fixes
branch
from
e5c6ddb to
c0d86c1
Compare
- Remove broken test in preset_utils we don't ever run - Move load_serialized_object to our preset loading class (for consistency) - Move all admin related tooling to a dedicated folder in tools/ - Remove some no longer used scripts.
mattdangerw
force-pushed
the
misc-fixes
branch
from
c0d86c1 to
9cd9ba6
Compare
SamanehSaadat
approved these changes
Dec 19, 2024
| ("llama2_7b_en_int8", "llama2_7b_en_int8", "bfloat16", True), | ||
| ) | ||
| @pytest.mark.extra_large | ||
| def test_load_serialized_object(self, preset, dtype, is_quantized): |
There was a problem hiding this comment.
Is this the test you mentioned it's broken and we don't run? It seems like a good test though!
There was a problem hiding this comment.
We could bring it back, but it's missing the mark on a few counts.
- Too big to run on our regular CI.
- Doesn't actually work.
- Not testing anything an end user would hit, it's just testing an internal utility in a way that will be brittle. We could test similar logic with
from_presetthat would be much less brittle.
Let's ditch for now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.