Skip to content

[OpenVINO backend] Added support for numpy.isclose operation #21138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

[OpenVINO backend] Added support for numpy.isclose operation #21138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fbfd36
Added decomposition for numpy.isclose
hridaya14 Apr 5, 2025
1b89acb
Removed test from excluded list
hridaya14 Apr 5, 2025
5e4ccf8
Fixed failed test cases
hridaya14 Apr 5, 2025
e3f6579
Fixed dtype error
hridaya14 Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions keras/src/backend/openvino/excluded_concrete_tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ NumpyDtypeTest::test_floor
NumpyDtypeTest::test_hstack
NumpyDtypeTest::test_identity
NumpyDtypeTest::test_inner
NumpyDtypeTest::test_isclose
NumpyDtypeTest::test_isfinite
NumpyDtypeTest::test_isinf
NumpyDtypeTest::test_isnan
Expand Down Expand Up @@ -157,12 +156,11 @@ NumpyTwoInputOpsCorrectnessTest::test_digitize
NumpyTwoInputOpsCorrectnessTest::test_divide_no_nan
NumpyTwoInputOpsCorrectnessTest::test_einsum
NumpyTwoInputOpsCorrectnessTest::test_inner
NumpyTwoInputOpsCorrectnessTest::test_isclose
NumpyTwoInputOpsCorrectnessTest::test_linspace
NumpyTwoInputOpsCorrectnessTest::test_logspace
NumpyTwoInputOpsCorrectnessTest::test_outer
NumpyTwoInputOpsCorrectnessTest::test_quantile
NumpyTwoInputOpsCorrectnessTest::test_take_along_axis
NumpyTwoInputOpsCorrectnessTest::test_tensordot
NumpyTwoInputOpsCorrectnessTest::test_vdot
NumpyTwoInputOpsCorrectnessTest::test_where
NumpyTwoInputOpsCorrectnessTest::test_where
19 changes: 16 additions & 3 deletions keras/src/backend/openvino/numpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,9 +778,22 @@ def imag(x):


def isclose(x1, x2, rtol=1e-5, atol=1e-8, equal_nan=False):
raise NotImplementedError(
"`isclose` is not supported with openvino backend"
)
dtype = OPENVINO_DTYPES[config.floatx()]

x1 = ov_opset.convert(get_ov_output(x1), dtype)
x2 = ov_opset.convert(get_ov_output(x2), dtype)
rtol = ov_opset.convert(get_ov_output(rtol), dtype)
atol = ov_opset.convert(get_ov_output(atol), dtype)

abs_diff = ov_opset.abs(x1 - x2)
abs_x2 = ov_opset.abs(x2)
total_tolerance = atol + rtol * abs_x2
is_close = ov_opset.less_equal(abs_diff, total_tolerance)
if equal_nan:
both_nan = ov_opset.logical_and(ov_opset.isnan(x1), ov_opset.isnan(x2))
is_close = ov_opset.logical_or(is_close, both_nan)

return OpenVINOKerasTensor(is_close.output(0))


def isfinite(x):
Expand Down