Skip to content

[OpenVINO backend] Support numpy.expm1 #21141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025
Merged

Conversation

Huanli-Gong
Copy link
Contributor

@Huanli-Gong Huanli-Gong commented Apr 6, 2025

Details:

  • Adds numpy.expm1 function to OpenVino backend.

Tickets:

Copy link

google-cla bot commented Apr 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (acd6f3c) to head (a0498ea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21141   +/-   ##
=======================================
  Coverage   82.68%   82.69%           
=======================================
  Files         564      564           
  Lines       54132    54141    +9     
  Branches     8411     8412    +1     
=======================================
+ Hits        44761    44770    +9     
  Misses       7296     7296           
  Partials     2075     2075           
Flag Coverage Δ
keras 82.50% <100.00%> (+<0.01%) ⬆️
keras-jax 64.06% <0.00%> (-0.02%) ⬇️
keras-numpy 59.08% <0.00%> (-0.02%) ⬇️
keras-openvino 32.90% <100.00%> (+0.02%) ⬆️
keras-tensorflow 64.34% <0.00%> (-0.02%) ⬇️
keras-torch 64.10% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rkazants
Copy link
Contributor

rkazants commented Apr 6, 2025

Fix this failed job - looks some agreement needs to be signed:
{3CBC90C4-6B54-4968-B6E7-E1638FCBE69A}

@Huanli-Gong
Copy link
Contributor Author

Fixed @rkazants

@rkazants
Copy link
Contributor

rkazants commented Apr 6, 2025

@Huanli-Gong, can you please do one more extra commit (that does nothing) to avoid sporadic failure in CI with torch?

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 7, 2025
@fchollet fchollet merged commit 9f3ab34 into keras-team:master Apr 7, 2025
7 checks passed
chiruu12 pushed a commit to chiruu12/keras that referenced this pull request Apr 11, 2025
* [OpenVINO backend] Support numpy.expm1

* remove a line with NumpyOneInputOpsCorrectnessTest::test_expm1

* does nothing

* does nothing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.expm1 operation
5 participants