Skip to content

Fix message formatting #21241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

Fix message formatting #21241

merged 2 commits into from
May 3, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR updates message strings by adding missing f-strings to properly evaluate variable values. I initially noticed one missing f-string and then reviewed the codebase for similar cases. Hopefully, I’ve caught them all.

Signed-off-by: Emmanuel Ferdman <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (48a6692) to head (621ba7c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21241   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files         564      564           
  Lines       54501    54501           
  Branches     8469     8469           
=======================================
  Hits        45020    45020           
  Misses       7397     7397           
  Partials     2084     2084           
Flag Coverage Δ
keras 82.41% <ø> (ø)
keras-jax 63.68% <ø> (ø)
keras-numpy 58.81% <ø> (ø)
keras-openvino 33.00% <ø> (ø)
keras-tensorflow 64.09% <ø> (ø)
keras-torch 63.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Emmanuel Ferdman <[email protected]>
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 3, 2025
@fchollet fchollet merged commit 4c6b7e3 into keras-team:master May 3, 2025
7 checks passed
@gbaned gbaned added this to PR Queue May 5, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:S
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants