Skip to content

Add openvino backend support for numpy.hstack #21257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025

Conversation

Imokutmfon
Copy link
Contributor

@Imokutmfon Imokutmfon commented May 7, 2025

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (5f2793e) to head (bd8fa37).

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21257      +/-   ##
==========================================
- Coverage   82.55%   82.55%   -0.01%     
==========================================
  Files         564      564              
  Lines       54638    54649      +11     
  Branches     8497     8499       +2     
==========================================
+ Hits        45105    45114       +9     
- Misses       7442     7443       +1     
- Partials     2091     2092       +1     
Flag Coverage Δ
keras 82.36% <81.81%> (-0.01%) ⬇️
keras-jax 63.62% <0.00%> (-0.02%) ⬇️
keras-numpy 58.73% <0.00%> (-0.01%) ⬇️
keras-openvino 32.99% <81.81%> (+0.01%) ⬆️
keras-tensorflow 64.02% <0.00%> (-0.02%) ⬇️
keras-torch 63.67% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Imokutmfon Imokutmfon marked this pull request as ready for review May 7, 2025 12:44
@rkazants
Copy link
Contributor

rkazants commented May 7, 2025

@Imokutmfon
Copy link
Contributor Author

Hi @rkazants
please review.
I am not authorized to push too

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 8, 2025
@fchollet fchollet merged commit 8d22f21 into keras-team:master May 8, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.hstack operation
5 participants