Allow directories in kiwix-serve paths #743
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the spelling mistake in zimPathes.
Added the ability to provide a directory path along with files. If the path provided is a directory, we recursively scan it and either add the files in it or go through the same operation for sub directories.
kelson42
requested changes
May 4, 2025
There was a problem hiding this comment.
@juuz0 Thank you for your code. Here my remarks:
- Please update the
usage() - It should add only the .zim .ZIM .zimaa .ZIMAA files, all the others should be ignored
- There is no security avoiding loop parsing following directory symlinks (you need to keep track of real directory paths to avoid looping).
- I would really like to have the code in libkiwix to be able to share it with Kiwix Desktop (or there is a reason already why this is not shared)?
All of this said - and this is not the less important - it works from a user perspective :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #739
Added the ability to provide directories along with filePaths in
kiwix-serveExample usage:
kiwix-serve --port 8080 directoryPath filePath anotherDirectoryPathFor a file structure of this kind:
Output (note the
verboseflag):