Skip to content

Use fake language in our translation unit tests. #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgautierfr opened this issue Apr 13, 2022 · 7 comments · Fixed by #848
Closed

Use fake language in our translation unit tests. #749

mgautierfr opened this issue Apr 13, 2022 · 7 comments · Fixed by #848
Assignees
@veloman-yunkan
Labels
enhancement good first issue
Milestone
12.0.0

Comments

@mgautierfr
Copy link
Member

Following #679

The current tests on translation are based on Armenian language. But it is subject to translation made on translatewiki.
We should use a fake language we could use on test to be sure that translator will not break our tests.
@kelson42 kelson42 added this to the 10.2.0 milestone Apr 13, 2022
@kelson42 kelson42 modified the milestones: 10.2.0, 10.3.0 Apr 23, 2022
@kelson42
Copy link
Collaborator

Translatewiki uses « qqq » for comments abour strings. Maybe you can reuse that code?

@veloman-yunkan
Copy link
Collaborator

qqq.json contains only descriptions of messages without placeholders for parameters that must be replaced in the real message. Thus using qqq pseudolanguage in the unit tests will not verify that parameters are properly set in the code.

@kelson42
Copy link
Collaborator

000 ?

@mgautierfr
Copy link
Member Author

Or test ?

@kelson42
Copy link
Collaborator

kelson42 commented Jul 3, 2022

@mgautierfr @veloman-yunkan Can we go forward with test

@kelson42
Copy link
Collaborator

@mgautierfr @veloman-yunkan please use artificial test Language for testing

@kelson42
Copy link
Collaborator

kelson42 commented Nov 2, 2022

@veloman-yunkan Woukd be good if that one could be implemented. Seems straight forward.

veloman-yunkan added a commit that referenced this issue Nov 17, 2022
@veloman-yunkan
Introduced a fake language for testing
bf2fb32 
We need a fake language for tests that won't be affected by
modifications made by 3rd party translators (see #749).

- static/skin/i18n/hy.json was cloned as static/skin/i18n/test.json
- usage of "hy" in unit-tests was replaced with "test"
@veloman-yunkan veloman-yunkan mentioned this issue Nov 17, 2022
Merged
veloman-yunkan added a commit that referenced this issue Nov 26, 2022
@veloman-yunkan
Introduced a fake language for i18n testing
956289d 
We need a fake language for tests that won't be affected by
modifications made by 3rd party translators (see #749).

- static/i18n/hy.json was cloned as static/i18n/test.json
- usage of "hy" in unit-tests was replaced with "test"
@veloman-yunkan veloman-yunkan mentioned this issue Nov 26, 2022
Merged
@kelson42 kelson42 modified the milestones: 12.1.0, 12.0.0 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veloman-yunkan veloman-yunkan

Labels
enhancement good first issue
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

Fake language for internationalization testing kiwix/libkiwix
3 participants
@mgautierfr @kelson42 @veloman-yunkan