Skip to content

Illustration size on book tile is fixed to 48x48 #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

veloman-yunkan
Copy link
Collaborator

Fixes #1102

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.43%. Comparing base (c29cd8c) to head (a63a162).
Report is 50 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files          59       59           
  Lines        4245     4245           
  Branches     2323     2323           
=======================================
  Hits         1759     1759           
  Misses        990      990           
  Partials     1496     1496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

kelson42 commented Sep 9, 2024

To me it looks good! @benoit74 ?

@benoit74
Copy link

benoit74 commented Sep 9, 2024

Looks good, to be tested in nightly obviously

@kelson42 kelson42 force-pushed the crisp_illustration_on_book_tile branch from 17a3bf3 to a63a162 Compare September 9, 2024 17:47
@kelson42 kelson42 merged commit d5a44b9 into main Sep 9, 2024
15 checks passed
@kelson42 kelson42 deleted the crisp_illustration_on_book_tile branch September 9, 2024 18:03
@benoit74
Copy link

I confirm this work as intended in nightly, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZIM Illustration is resized in the catalog UI and hence a bit blurry
3 participants