favicon: improve PWA and cross-platform icon support #1186
Conversation
|
Requesting you to review this PR. |
|
Hi @rgaudin @veloman-yunkan @kelson42 Requesting you to review this PR. |
|
Looks OK ; requested review from maintainers |
|
I don't think it fixes said ticket though… |
|
Please help in reviewing this PR. |
|
This does not fix #716 AFAIZk |
kelson42
force-pushed
the
kiwix-tools_issues-716
branch
from
7052b24 to
1196a7c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
=======================================
Coverage 41.45% 41.45%
=======================================
Files 59 59
Lines 4289 4289
Branches 2349 2349
=======================================
Hits 1778 1778
Misses 999 999
Partials 1512 1512 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you for the review. I have updated the description that it Fixes: #1189 Please take a look and merge this PR. |
|
First item in the ticket is
There is no asset change in the PR. I am using this PR as an opportunity to discuss kiwix-serve's Icon. It is currently using the Kiwix bird (we might want to check that it's the proper one – margin wise). While it would have already been possible for browsers (especially on mobile) to save this as an app, this new manifest makes it explicit. Is this bird-only icon what we for for a PWA of kiwix-serve? @kelson42 ? |
Add proper configuration for Progressive Web App (PWA) and platform-specific icons across the application. Changes include: - Update site.webmanifest with correct icon purposes for PWA - Add Android Chrome icons (192x192, 512x512) to HTML - Add Windows tile image configuration - Ensure consistency between JS and no-JS pages This ensures proper icon display across all platforms while following platform-specific best practices for icon implementation.
kelson42
force-pushed
the
kiwix-tools_issues-716
branch
from
1196a7c to
c8bce1d
Compare
|
@Optimus-NP Thank you for your PR... and your patience. I have rebased it on the latest version of |
Fixes: #1189
Add proper configuration for Progressive Web App (PWA) and platform-specific icons across the application. Changes include:
This ensures proper icon display across all platforms while following platform-specific best practices for icon implementation.