Support 'video/*' * 'audio/*' mimetypes in getMediaCount() #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 59.61% 59.64% +0.02%
==========================================
Files 51 51
Lines 3400 3402 +2
Branches 1711 1713 +2
==========================================
+ Hits 2027 2029 +2
Misses 1370 1370
Partials 3 3
Continue to review full report at Codecov.
|
veloman-yunkan
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
I overcame the temptation to turn the review process of this simple change into an exhausting marathon. Life is too short for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438