Skip to content

Use C++11 std::thread instead of pthread. #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Use C++11 std::thread instead of pthread. #445

merged 3 commits into from
Jan 26, 2021

Conversation

mgautierfr
Copy link
Member

This is necessary as libzim now does the same and we don't install wrapper pthread library on windows CI.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #445 (24b2e6e) into master (f5d9a37) will decrease coverage by 0.04%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   59.77%   59.73%   -0.05%     
==========================================
  Files          51       50       -1     
  Lines        3416     3410       -6     
  Branches     1721     1725       +4     
==========================================
- Hits         2042     2037       -5     
+ Misses       1371     1370       -1     
  Partials        3        3              
Impacted Files Coverage Δ
include/downloader.h 0.00% <ø> (ø)
src/entry.cpp 50.00% <ø> (ø)
src/server/internalServer.cpp 86.39% <ø> (ø)
src/subprocess_unix.cpp 0.00% <0.00%> (ø)
src/tools/regexTools.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d9a37...24b2e6e. Read the comment docs.

@mgautierfr mgautierfr merged commit c81c2a4 into master Jan 26, 2021
@mgautierfr mgautierfr deleted the no_pthread branch January 26, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants