Skip to content

Do not crash if zim file has no Counter metadata. #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

mgautierfr
Copy link
Member

@mgautierfr mgautierfr commented Jan 26, 2021

Fix #447

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #449 (4749656) into master (e0bcafd) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   59.78%   59.77%   -0.01%     
==========================================
  Files          51       51              
  Lines        3414     3416       +2     
  Branches     1732     1721      -11     
==========================================
+ Hits         2041     2042       +1     
- Misses       1370     1371       +1     
  Partials        3        3              
Impacted Files Coverage Δ
src/reader.cpp 48.37% <75.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bcafd...4749656. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git master head is not able to read properly older pokepedia ZIM file
2 participants