-
-
Notifications
You must be signed in to change notification settings - Fork 62
Extend libkiwix structures to be contructed/updated from libzim structures #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After the changes of the last PR and this PR, the use of @mgautierfr I guess we have covered all the wrapper structures now excluding JNI. Is there anything I am missing? |
This PR depends upon openzim/libzim#582 |
I guess this PR would benefit of a rebase |
280262a
to
7f46fdd
Compare
@kelson42 done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things to change.
Please rebase (again) on master to make the CI download the correct dependencies archive.
Remove the draft status on the PR (if accurate) (remove WIP from the title is not enough)
7f46fdd
to
8eeef00
Compare
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 65.17% 64.79% -0.39%
==========================================
Files 53 53
Lines 3765 3730 -35
Branches 1886 1856 -30
==========================================
- Hits 2454 2417 -37
- Misses 1309 1311 +2
Partials 2 2
Continue to review full report at Codecov.
|
@maneeshpm Does it fix #166. If not, updating #166 with what is left to do would be helpful. |
8eeef00
to
c1ede74
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@mgautierfr Can we merge this? |
c1ede74
to
1219b50
Compare
@kelson42 rebase fixup done. |
Some methods in kiwix::Book uses wrapper structure reader. This usage should be extended from the native libzim structure zim::Archive
kiwix::Manager uses Reader to import a zim file, it should be using zim::Archive directly.
1219b50
to
19afe94
Compare
Fixes #430
This PR depends upon #536
This is the second stage to remove usage of wrapper structures from libkwix. In this step, we will extend the libkiwix structures to use libzim structures directly. This will still include the wrapper structures in the API but their usage will be derived from that of libzim structures.
Changes included in this PR:
kiwix::Book
to be updated from azim::Archive
kiwix::Manager
to import a zim file from azim::Archive
Add overloads for libzim structure in kiwix::Book