Skip to content

PPA: Add kinetic #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2022
Merged

PPA: Add kinetic #801

merged 1 commit into from
Nov 13, 2022

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jul 25, 2022

Not sure why this is broken, debugging...

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #801 (98bcf8a) into master (3facd59) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 98bcf8a differs from pull request most recent head 9305a87. Consider uploading reports for the commit 9305a87 to get more accurate results

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   70.63%   70.65%   +0.02%     
==========================================
  Files          53       53              
  Lines        3708     3708              
  Branches     2061     2061              
==========================================
+ Hits         2619     2620       +1     
+ Misses       1087     1086       -1     
  Partials        2        2              
Impacted Files Coverage Δ
src/server/response.cpp 92.46% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd90ca1...9305a87. Read the comment docs.

@kelson42 kelson42 added this to the 12.0.0 milestone Jul 27, 2022
@kelson42
Copy link
Collaborator

kelson42 commented Aug 6, 2022

@legoktm Any news? CI still fail all the time.

@kelson42 kelson42 force-pushed the legoktm-patch-1 branch 2 times, most recently from abdbfb1 to c8e30fe Compare August 12, 2022 09:32
@kelson42
Copy link
Collaborator

I guess we will have to live with this bug for 12.0.0 release.

@kelson42 kelson42 modified the milestones: 12.0.0, 12.1.0 Aug 12, 2022
@kelson42
Copy link
Collaborator

@legoktm Any news, this is really a concern to have this not working during months

@stale
Copy link

stale bot commented Nov 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 2, 2022
@kelson42 kelson42 self-requested a review November 7, 2022 12:27
@stale stale bot removed the stale label Nov 7, 2022
@kelson42 kelson42 modified the milestones: 12.1.0, 12.0.0 Nov 7, 2022
@kelson42 kelson42 changed the title PPA: Drop impish, add kinetic PPA: Add kinetic Nov 13, 2022
@kelson42 kelson42 marked this pull request as ready for review November 13, 2022 20:03
@kelson42 kelson42 merged commit 8031ffa into master Nov 13, 2022
@kelson42 kelson42 deleted the legoktm-patch-1 branch November 13, 2022 20:03
mgautierfr added a commit that referenced this pull request Nov 30, 2022
* [API Break] Remove wrapper around libzim (@mgautierfr #789)
* Allow kiwix-serve to use custom resource files (@veloman-yunkan #779)
* Properly handle searchProtocolPrefix when rendering search result (@veloman-yunkan #823)
* Prevent search on multi language content (@veloman-yunkan #838)
* Use new `zim::Archive::getMediaCount` from libzim (@mgautierfr #836)
* Catalog:
 - Include tags in free text catalog search (@veloman-yunkan #802)
 - Illustration's url is based on book's uuid (@veloman-yunkan #804)
 - Cleanup of the opds-dumper (@veloman-yunkan #829)
 - Allow filtering of catalog content using multiple languages (@veloman-yunkan #841)
 - Make opds-dumper respect the namemapper (@mgautierfr #837)
* Server:
 - Correctly handle `\` in suggestion json generation (@veloman-yunkan #843)
 - Better http caching (@veloman-yunkan #833)
 - Make `/suggest` endpoint thread-safe (@veloman-yunkan #834)
 - Better redirection of main page (@veloman-yunkan #827)
 - Remove jquery (@mgautierfr @juuz0 #796)
 - Better Viewer of zim content :
   . Introduce `/content` endpoints (@veloman-yunkan #806)
   . Switch to iframe based content viewer (@veloman-yunkan #716)
 - Optimised design of the welcome page:
   . Alignement (@juuz0 @kelson42 #786)
   . Exit download modal on pressing escape key (@Juzz0 #800)
   . Add favicon for different devices (@Juzz0 #805)
   . Fix auto hidding of the toolbar (@veloman-yunkan #821)
   . Allow user to filter books by tags in the front page (@juuz0 #711)
* CI :
  - Trigger CI on pull_request (@kelson42 #791)
  - Drop Ubuntu Impish packaging (@legoktm #825)
  - Add Ubuntu Kinetic packaging (@legoktm #801)
* Testing:
  - Test ICULanguageInfo (@veloman-yunkan #795)
  - Introduce fake `test` language to test i18n (@veloman-yunkan #848)
* Fix documentation (@kelson42 #816)
* Udpate translation (#787 #839 #847)
@mgautierfr mgautierfr mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants