User language control in the server

[veloman-yunkan]

Fixes #750

Depends on #848

kiwix server determines the user language from three sources (in that order, earlier source takes precedence):

• userlang URL query parameter
• userlang cookie
• Accept-Language header

In all cases, the server sets the userlang cookie in its response using thus determined language.

If Accept-Language is used and multiple language options are specified with weights, then the most suitable language is selected by scoring available translation languages - the score value is computed as the product of weight value and the number of translated strings for that language.

[codecov]

Codecov Report

Base: 71.04% // Head: 71.04% // No change to project coverage 👍

Coverage data is based on head (aa7053b) compared to base (aa7053b).
Patch has no changes to coverable lines.

❗ Current head aa7053b differs from pull request most recent head 28e9fb4. Consider uploading reports for the commit 28e9fb4 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   71.04%   71.04%           
=======================================
  Files          53       53           
  Lines        3685     3685           
  Branches     2058     2058           
=======================================
  Hits         2618     2618           
  Misses       1065     1065           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[veloman-yunkan]

Note that in this version dialects/language variants (like en-US, fr-XVI, etc) are treated as regular languages - no attempt to convert them into language codes that are available in our translation database is performed.

[mgautierfr]

A small question/update but we are mostly good.

[kelson42]

Note that in this version dialects/language variants (like en-US, fr-XVI, etc) are treated as regular languages - no attempt to convert them into language codes that are available in our translation database is performed.

Note that in this version dialects/language variants (like en-US, fr-XVI, etc) are treated as regular languages - no attempt to convert them into language codes that are available in our translation database is performed.

What is the user impact of that, this seems important that fr-CH delivers fr in case we don't have any fr-CH translations.

[kelson42]

It seems here, no javascript file is changed, so I wonder about my comment #750 (comment). How should we do, to change the code which handle the langauge selection box from javascript to c++?

[veloman-yunkan]

What is the user impact of that, this seems important that fr-CH delivers fr in case we don't have any fr-CH translations.

@kelson42 I would prefer to address that in a separate PR (after this one and #846 are merged).

[kelson42]

What is the user impact of that, this seems important that fr-CH delivers fr in case we don't have any fr-CH translations.

@kelson42 I would prefer to address that in a separate PR (after this one and #846 are merged).

Can you please open a ticket for that? Otherwise it will be forgotten until a user complain about it.

[veloman-yunkan]

It seems here, no javascript file is changed, so I wonder about my comment #750 (comment). How should we do, to change the code which handle the langauge selection box from javascript to c++?

@kelson42 That is addressed in #846.

[mgautierfr]

Rebased on master and fixed-up.
I'm merging.