Skip to content

Add OpenHydroponics input module #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mickeprag
Copy link

No description provided.

@kizniche
Copy link
Owner

This failed the test. It will need to have the import handled differently so it can pass the test.

@mickeprag
Copy link
Author

I will have a look at the tests. I put this as a draft since I just want to know if I am on the right track.

@kizniche
Copy link
Owner

Ah, I didn't notice the draft. I'm that case, yes, it looks very good. The tests can be run locally to test if they pass. The following will run all tests:

cd /opt/Mycodo/mycodo
/opt/Mycodo/env/bin/pytest -s tests/software_tests

You can add this to run a specific test and save time: -k 'specific_test_name'

This happens during testing
@mickeprag
Copy link
Author

I think I solved the test issue. Could you run the CI testing again, please?

@mickeprag
Copy link
Author

Ok, still errors. But at least another error this time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants