Closed
Description
References #762 (comment)
It seems that the Content-Type header is not set when the size of the response body is smaller than the jitter entropy buffer, which doesn't seem like normal behavior at a first glance. As requested, please find a reproduction below:
func TestContentTypeDetectWithJitter(t *testing.T) {
t.Parallel()
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
content := `<!DOCTYPE html>` + strings.Repeat("foo", 400)
w.Write([]byte(content))
})
for _, tc := range []struct {
name string
wrapper func(http.Handler) (http.Handler, error)
}{
{
name: "no wrapping",
wrapper: func(h http.Handler) (http.Handler, error) {
return h, nil
},
},
{
name: "default",
wrapper: func(h http.Handler) (http.Handler, error) {
wrapper, err := NewWrapper()
if err != nil {
return nil, err
}
return wrapper(h), nil
},
},
{
name: "jitter, default buffer",
wrapper: func(h http.Handler) (http.Handler, error) {
wrapper, err := NewWrapper(RandomJitter(32, 0, false))
if err != nil {
return nil, err
}
return wrapper(h), nil
},
},
{
name: "jitter, small buffer",
wrapper: func(h http.Handler) (http.Handler, error) {
wrapper, err := NewWrapper(RandomJitter(32, DefaultMinSize, false))
if err != nil {
return nil, err
}
return wrapper(h), nil
},
},
} {
tc := tc
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
handler, err := tc.wrapper(handler)
assertNil(t, err)
req, resp := httptest.NewRequest(http.MethodGet, "/", nil), httptest.NewRecorder()
req.Header.Add("Accept-Encoding", "gzip")
handler.ServeHTTP(resp, req)
assertEqual(t, "text/html; charset=utf-8", resp.Header().Get("Content-Type"))
})
}
}On go version go1.21.3 darwin/arm64 this outputs:
--- FAIL: TestContentTypeDetectWithJitter (0.00s)
--- FAIL: TestContentTypeDetectWithJitter/jitter,_default_buffer (0.00s)
/Users/adriansmares/projects/compress/gzhttp/compress_test.go:1716: want "text/html; charset=utf-8", got "application/x-gzip"
FAIL
FAIL github.com/klauspost/compress/gzhttp 0.181s
FAIL
As mentioned in the original issue, I think the culprit is the jitter buffer size guard added here:
Lines 127 to 130 in 847c1b4
I cannot tell what was the original intent, but I would've expected that the size of the entropy pool won't affect the Content-Type logic.
cc @klauspost (and apologies for the original necropost).
Metadata
Metadata
Assignees
Labels
No labels