Skip to content
This repository was archived by the owner on Jun 4, 2021. It is now read-only.

Port KafkaSource to cloudevents/sdk-go bindings #975

Closed
slinkydeveloper opened this issue Feb 28, 2020 · 0 comments · Fixed by #1037
Closed

Port KafkaSource to cloudevents/sdk-go bindings #975

slinkydeveloper opened this issue Feb 28, 2020 · 0 comments · Fixed by #1037

Comments

@slinkydeveloper
Copy link
Contributor

Problem
Now the KafkaSource adapter uses the Client APIs of cloudevents/sdk-go

Exit Criteria
KafkaSource adapter uses only the bindings APIs of cloudevents/sdk-go

Time Estimate (optional):
1 week

Additional context (optional)
The new bindings API are designed to improve cpu/memory efficiency for transporting events.

Depends on knative/eventing#2672

slinkydeveloper added a commit to slinkydeveloper/eventing-contrib that referenced this issue Feb 28, 2020
Signed-off-by: Francesco Guardiani <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/eventing-contrib that referenced this issue Mar 18, 2020
Signed-off-by: Francesco Guardiani <[email protected]>
slinkydeveloper added a commit to slinkydeveloper/eventing-contrib that referenced this issue Mar 18, 2020
Signed-off-by: Francesco Guardiani <[email protected]>
knative-prow-robot pushed a commit that referenced this issue Mar 18, 2020
* Started working on #975

Signed-off-by: Francesco Guardiani <[email protected]>

* KafkaSource now uses bindings!

Signed-off-by: Francesco Guardiani <[email protected]>

* Fixed the benchmark

Signed-off-by: Francesco Guardiani <[email protected]>

* Fix

Signed-off-by: Francesco Guardiani <[email protected]>

* Fixed missing Finish() call

Signed-off-by: Francesco Guardiani <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant