Skip to content

Add Delivery to Parallel API #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2020
Merged

Add Delivery to Parallel API #3148

merged 2 commits into from
May 15, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 15, 2020

Fixes #3145

Proposed Changes

  • Add Delivery to parallel for DLQ

Release Note

- 🎁 Add new feature
Add Delivery to parallel branches.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 15, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/parallel/parallel.go 69.2% 69.4% 0.2

@vaikas vaikas changed the title Issue 3145 Add Delivery to Parallel API May 15, 2020
@lionelvillard
Copy link
Member

/lgtm

Thanks for doing that!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@knative-prow-robot knative-prow-robot merged commit 4a46aff into knative:master May 15, 2020
@vaikas vaikas deleted the issue-3145 branch May 15, 2020 16:01
@tzununbekov tzununbekov mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslom aslom Awaiting requested review from aslom

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallel does not expose Delivery parameter.
5 participants
@vaikas @knative-prow-robot @knative-metrics-robot @lionelvillard @googlebot