-
Notifications
You must be signed in to change notification settings - Fork 612
Set correct namespace for namespace reconciliation events #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct namespace for namespace reconciliation events #3258
Conversation
Signed-off-by: Ahmed Abdalla <[email protected]>
/assign @grantr |
The following is the coverage report on the affected files.
|
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/honk |
/woof |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/unhold |
/uncc slinkydeveloper |
/honk /honk |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Abd4llA, matzew, n3wscott, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Namespace events created during reconciliation end up in
default
namespace. This gives a bad and unexpected UX for Eventing users since in our case, the user is interacting with Triggers and Brokers that are in a specific namespace and expects Events being there.Fixes #3084
Proposed Changes
Release Note