Introduce sugar-controller, the reconciler that deals with annotation and label based eventing enablement

[n3wscott]

The current eventing namespace and trigger reconcilers act on labels and annotations in those components to create eventing components in the given namespace for a given broker. The trigger controller was not acting as expected, it would auto-label the namespace because of a long history of the complications needed to install a broker (service account, roles, and role bindings, plus broker). Today we just need the broker object to be created.

We can enable the interactions with these labels as an optional installable controller that enables "sugar" onto the other Kubernetes resources.

Proposed Changes

• Remove Namespace reconciler from core.
• Remove Trigger reconciler from core.
• Introduce a new controller to host the new Namespace and Trigger reconcilers for sugar.

Release Note

Installing sugar-controller will provide namespace label and trigger annotation based enablement of Knative Eventing in a namespace.

Docs

• Document installing Eventing Sugar Controller docs#2647

[mattmoor]

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

[mattmoor]

Format markdown:

Suggested change

	The sugar controller is an optional reconciler that watches for labels
	and annotations on certain resources to inject eventing components.
	The sugar controller is an optional reconciler that watches for labels and
	annotations on certain resources to inject eventing components.

[mattmoor]

Format markdown:

Suggested change

[mattmoor]

Format markdown:

Suggested change

	kubectl -n knative-eventing set env deployment/sugar-controller BROKER_INJECTION_DEFAULT=true
	kubectl -n knative-eventing set env deployment/sugar-controller BROKER_INJECTION_DEFAULT=true

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[lgtm-com]

This pull request introduces 2 alerts when merging dfc3dfd into 17b2978 - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[lgtm-com]

This pull request introduces 2 alerts when merging 3ed614f into 17b2978 - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[lgtm-com]

This pull request introduces 2 alerts when merging 988b727 into a70e05c - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[vaikas]

I assume you're going to create a release artifact also?

[vaikas]

Addresses: #3138

[vaikas]

Maybe modify the CRD shape to default the trigger Status to 'no b0rk3r':
#2996

[n3wscott]

/retest

[vaikas]

/lgtm
/approve

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [n3wscott,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-integration-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestDefaultBrokerWithManyTriggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_deprecated_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers_using_v1beta1_trigger
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers
test/e2e.TestApiServerSourceV1Alpha2EventTypes
test/e2e.TestPingSourceV1Alpha2EventTypes
test/e2e.TestTriggerDependencyAnnotation

[n3wscott]

Error from server (NotFound): deployments.apps "sugar-controller" not found

whoops! labeled the wrong namespace deployment.

[vaikas]

monitoring (elastic search didn't come up), retrying...

Error from server (BadRequest): container "elasticsearch-logging" in pod "elasticsearch-logging-1" is waiting to start: PodInitializing

/test pull-knative-eventing-integration-tests

[vaikas]

/lgtm

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/eventing/v1/trigger_validation.go	96.2%	96.3%	0.1
pkg/apis/eventing/v1beta1/trigger_validation.go	96.2%	96.2%	-0.1
pkg/reconciler/sugar/filters.go	Do not exist	60.0%
pkg/reconciler/sugar/labels.go	Do not exist	33.3%
pkg/reconciler/sugar/namespace/controller.go	Do not exist	85.7%
pkg/reconciler/sugar/namespace/namespace.go	Do not exist	85.7%
pkg/reconciler/sugar/trigger/controller.go	Do not exist	57.1%
pkg/reconciler/sugar/trigger/trigger.go	Do not exist	84.6%

[knative-prow-robot]

@n3wscott: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-eventing-go-coverage	756f233	link	/test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vaikas]

/lgtm