feat: Add global env #1305
Comments
nmittler
added a commit
to nmittler/ko
that referenced
this issue
May 14, 2024
Supports configuring global `env` variables that will be applied to all builds. Modifies the `builder` function to accept a `buildContext` structure. This will simplify similar modifications in the future. Fixes ko-build#1305 Signed-off-by: Nathan Mittler <[email protected]>
Merged
nmittler
added a commit
to nmittler/ko
that referenced
this issue
May 14, 2024
Supports configuring global `env` variables that will be applied to all builds. Modifies the `builder` function to accept a `buildContext` structure. This will simplify similar modifications in the future. Fixes ko-build#1305 Signed-off-by: Nathan Mittler <[email protected]>
nmittler
added a commit
to nmittler/ko
that referenced
this issue
May 14, 2024
Supports configuring global `env` variables that will be applied to all builds. Modifies the `builder` function to accept a `buildContext` structure. This will simplify similar modifications in the future. Fixes ko-build#1305 Signed-off-by: Nathan Mittler <[email protected]>
nmittler
added a commit
to nmittler/ko
that referenced
this issue
May 14, 2024
Supports configuring global `env` variables that will be applied to all builds. Modifies the `builder` function to accept a `buildContext` structure. This will simplify similar modifications in the future. Fixes ko-build#1305 Signed-off-by: Nathan Mittler <[email protected]>
nmittler
added a commit
to nmittler/ko
that referenced
this issue
May 14, 2024
Supports configuring global `env` variables that will be applied to all builds. Modifies the `builder` function to accept a `buildContext` structure. This will simplify similar modifications in the future. Fixes ko-build#1305 Signed-off-by: Nathan Mittler <[email protected]>
nmittler
added a commit
to nmittler/ko
that referenced
this issue
May 17, 2024
Supports configuring global `env` variables that will be applied to all builds. Modifies the `builder` function to accept a `buildContext` structure. This will simplify similar modifications in the future. Fixes ko-build#1305 Signed-off-by: Nathan Mittler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If there are common environment variables used in each build in
.ko.yaml, this can creates a lot of boilerplate. It would be better to allow a set of global variables at the top, that will automatically available to each build as its generated.I suspect the order they should appear in the aggregate list is as follows:
os.EnivironenvenvHappy to do the work, if folks think this is a good idea.
The text was updated successfully, but these errors were encountered: