Exception fix for non-query compound requests #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the first request's type to match all others against, as the previous method would only update the type after the check was being performed
kobylynskyi
approved these changes
Jan 9, 2021
There was a problem hiding this comment.
@WouterG, looks good to me.
Thanks a lot for the contribution!
I will release it as part of 4.1.1 this weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I encountered a bug while using the GraphQLRequests#toHttpJsonBody method, causing it to be unable to compile requests of non-query types.
I swapped the code to use the first request's operation type instead of using the default QUERY type, as the value would only be updated in the loop, after the check with exception had already happened.
The operation of getting the first entry is safe to use as the list is checked before to not be empty.
Hope to hear from you, and have an update for our usage 👍