feat(stoneintg-1165): resolve pipelineruns from scenario

[14rcole]

Support referencing pipelineruns from integrationtestscenario resolver field. Uses Tekton's ResolutionRequest CR to grab remote data then creates PipelineRun in the cluster

Maintainers will complete the following section

• Commit messages are descriptive enough (hints)
• Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
• Controllers diagrams are updated when PR changes controllers code (if applicable)

[dirgim]

Note that manipulating ResolutionRequest CRs will probably require RBACs to be updated accordingly, which should be done by expanding the existing kubebuilder directives here:

integration-service/internal/controller/snapshot/snapshot_controller.go

Lines 57 to 70 in 88a813c

	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=snapshots,verbs=get;list;watch;create;update;patch;delete
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=snapshots/status,verbs=get;update;patch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=snapshots/finalizers,verbs=update
	//+kubebuilder:rbac:groups=tekton.dev,resources=pipelineruns,verbs=get;list;watch;create;update;patch;delete;deletecollection
	//+kubebuilder:rbac:groups=tekton.dev,resources=pipelineruns/status,verbs=get;update;patch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=applications/finalizers,verbs=update
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=applications,verbs=get;list;watch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=applications/status,verbs=get
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=components,verbs=get;list;watch;update;patch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=components/status,verbs=get;update;patch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=releases/status,verbs=get;update;patch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=releases,verbs=create;delete;get;list;patch;update;watch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=releaseplans,verbs=get;list;watch
	//+kubebuilder:rbac:groups=appstudio.redhat.com,resources=releaseplans/status,verbs=get;update;patch

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 18.94737% with 77 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6b5eae0). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
tekton/integration_pipeline.go	16.85%	73 Missing and 1 partial ⚠️
internal/controller/snapshot/snapshot_adapter.go	50.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage        ?   62.43%           
=======================================
  Files           ?       50           
  Lines           ?     7036           
  Branches        ?        0           
=======================================
  Hits            ?     4393           
  Misses          ?     2235           
  Partials        ?      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dirgim]

@14rcole how feasible would it be to provide unit test coverage for the pipelineRun resolution?

On first look, creating a new loader function to handle getting resolutionRequests (which is currently done here) and then using mock loaders to return a resolutionRequest with the correct status and a prepared pipelineRun yaml in its resolvedRequest.Status.Data field might be able to do most of the job, but I may be missing something.

[14rcole]

@dirgim I tried that but we can't import the loader package into the tekton package because it would create a circular dependency. I would have to migrate out either all of the constants or the functions related to creating the PipelineRuns. I decided that rather than take on such a big refactor here I would file a follow-up story. I confirmed manually that this works

[dirgim]

LGTM, nice work!

[kasemAlem]

great work @14rcole
/retest