feat(ISV-5859): Add index image SBOM generator #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Mobster can now generate SBOMs for index images that represents its multiarch structure. The script generates SBOMs in SPDX format using provided index manifest generated using Buildah/Skopeo. The generator uses spdx_tools library to assemble the document and before storing it to file it validates its schema. JIRA: ISV-5859 Signed-off-by: Ales Raszka <[email protected]>
|
/retest |
ezopezo
approved these changes
May 9, 2025
|
|
||
| for manifest in index_manifest["manifests"]: | ||
| if manifest["mediaType"] not in self.IMAGE_MANIFEST_MEDIA_TYPES: | ||
| LOGGER.warning( |
There was a problem hiding this comment.
I guess this is a case for potential emerging of new mediatype in future - shouldn't we rather end up with error and adapt script right away instead producing incomplete SBOM? Or are those warnings sufficiently visible in konflux runtime?
There was a problem hiding this comment.
We don't want to support any other mediatyes except those that are defined in the script. The warning is there tu just inform user that there is something that won't be present in the SBOM as it is not any convential image.
mavaras
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Mobster can now generate SBOMs for index images that represents its multiarch structure. The script generates SBOMs in SPDX format using provided index manifest generated using Buildah/Skopeo.
The generator uses spdx_tools library to assemble the document and before storing it to file it validates its schema.
JIRA: ISV-5859