Skip to content

Add final substrait tests for implemented string functions #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Ulimo
Copy link
Contributor

@Ulimo Ulimo commented Nov 28, 2024

This fixes #607

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d42827d Previous: 7db1083 Ratio
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin 566072730 ns (± 13624813.941159792) 588638700 ns (± 9231369.002121696) 0.96
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin 671699020 ns (± 20190657.89461387) 632393477.7777778 ns (± 23156158.76418074) 1.06
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization 219797940 ns (± 12234694.996625148) 171268600 ns (± 6644227.006958748) 1.28
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation 232033890 ns (± 15547723.49110956) 190822830 ns (± 6415026.852121856) 1.22
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation 2168459850 ns (± 78153685.57908833) 2656394200 ns (± 136074715.58524996) 0.82

This comment was automatically generated by workflow using github-action-benchmark.

@Ulimo Ulimo merged commit d1e9a08 into main Nov 28, 2024
6 checks passed
@Ulimo Ulimo deleted the substrait_compliance_strings branch November 28, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that existing string functions conform with substrait standard
1 participant