Refactor connection string handling for flexibility #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced direct usage of connection strings with a function that retrieves the connection string. This change allows for runtime generation or modification of the connection string. Updates were made across multiple files, including `BaseSqlRepository.cs`, `SessionRepository.cs`, `StorageRepository.cs`, `SqlServerPersistentStorage.cs`, `SqlServerPersistentStorageSettings.cs`, `SqlServerStorageExtensions.cs`, and `SqlStorageTests.cs`. The connection string is now accessed via a `ConnectionStringFunc` delegate, and corresponding tests have been updated to reflect this new structure.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 10e6977 | Previous: 22d4209 | Ratio |
|---|---|---|---|
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin |
405484905.5555556 ns (± 7225634.860015955) |
458826533.3333333 ns (± 10640413.19005047) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin |
483645072.2222222 ns (± 29506729.027620878) |
564994640 ns (± 28550338.329818636) |
0.86 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization |
149457300 ns (± 21283094.506569188) |
169842820 ns (± 7144067.768715523) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation |
168910850 ns (± 11171747.746087996) |
171581250 ns (± 12415362.812660772) |
0.98 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation |
1832900220 ns (± 98416435.89018159) |
1982296640 ns (± 123349811.75190067) |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the connection string handling to improve flexibility by replacing direct usage with a delegate-based approach.
- Updated multiple files to call ConnectionStringFunc() instead of using a hardcoded ConnectionString.
- Added an overload in SqlServerStorageExtensions to accept a connection string function, and updated tests accordingly.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SqlServerStorageExtensions.cs | Added overload to accept Func and updated connection string usage |
| BaseSqlRepository.cs | Replaced direct connection string usage with connection string function calls |
| SqlServerPersistentStorageSettings.cs | Changed connection string property type from string to Func |
| SqlServerPersistentStorage.cs | Updated connection string usage to use the delegate function |
| SessionRepository.cs | Updated connection string usage to call ConnectionStringFunc() |
| SqlStorageTests.cs | Updated settings to return connection string via Func |
| StorageRepository.cs | Replaced ConnectionString with ConnectionStringFunc() in SQL connection creation |
|
Looks great, would be super if the docs could be updated as well |
Updated docs with an example of the new functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced direct usage of connection strings with a function that retrieves the connection string.
This change allows for runtime generation or modification of the connection string. Updates were made across multiple files, including
BaseSqlRepository.cs,SessionRepository.cs,StorageRepository.cs,SqlServerPersistentStorage.cs,SqlServerPersistentStorageSettings.cs,SqlServerStorageExtensions.cs, andSqlStorageTests.cs.The connection string is now accessed via a
ConnectionStringFuncdelegate, and corresponding tests have been updated to reflect this new structure.