Refactor assertion property name in StringFunctionTests #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the property name in the assertion from `FirstLetter` to `NameParts` for better clarity. This change accurately reflects the data being processed by the `Regex.Split` method, which splits full names into their constituent parts.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: e141ee5 | Previous: 22d4209 | Ratio |
|---|---|---|---|
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin |
404284150 ns (± 13486511.621637212) |
458826533.3333333 ns (± 10640413.19005047) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin |
495693300 ns (± 12967077.33325697) |
564994640 ns (± 28550338.329818636) |
0.88 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization |
146970080 ns (± 18315732.419792674) |
169842820 ns (± 7144067.768715523) |
0.87 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation |
141688130 ns (± 17003960.14866341) |
171581250 ns (± 12415362.812660772) |
0.83 |
FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation |
1824941870 ns (± 123658159.00362669) |
1982296640 ns (± 123349811.75190067) |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
Ulimo
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the property name in the assertion from
FirstLettertoNamePartsfor better clarity. This change accurately reflects the data being processed by theRegex.Splitmethod, which splits full names into their constituent parts.